[PATCH] D22848: [ELF] - Linkerscript: ignore SORT(CONSTRUCTORS)

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 11:12:41 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D22848#497954, @davide wrote:

> This LGTM, but, doesn't this collide with your other SORT() patch?


Good question. Technically as far I understand, CONSTRUCTORS is outputsection keyword, which should be used inside SORT() at the top level.
All files wildcards I saw starts from '*', https://reviews.llvm.org/D22852 relies on that (and I think it is reasonable).
We are also do not plan to support sort by filenames AFAIK as nothing uses that.

So I think we can handle SORT(CONSTRUCTORS) just like it would be a single command to simplify processing, like that patch do.


https://reviews.llvm.org/D22848





More information about the llvm-commits mailing list