[PATCH] D21189: Create subranges for new intervals resulting from live interval splitting

[Sergey Yakushkin via llvm-commits]

yakush added inline comments.

================
Comment at: lib/CodeGen/LiveRangeCalc.cpp:232
@@ -209,2 +231,3 @@
+    extend(LR, UseIdx, Reg, AllowUndef);
   }
 }
----------------
does it handle partial register uses?

================
Comment at: lib/CodeGen/LiveRangeCalc.cpp:229
@@ -207,3 +228,3 @@
     // reading Reg multiple times. That is OK, extend() is idempotent.
-    extend(LR, UseIdx, Reg);
+    extend(LR, UseIdx, Reg, AllowUndef);
   }
----------------
why LaneBitmask can be omitted in this call of ::extend?

================
Comment at: lib/CodeGen/LiveRangeCalc.cpp:389
@@ -300,3 +388,3 @@
     if (TargetRegisterInfo::isPhysicalRegister(PhysReg) &&
         !MBB->isLiveIn(PhysReg)) {
       MBB->getParent()->verify();
----------------
code assumes PhysReg here can't be sub-registers. if livein contains super-register and PhysReg is sub-register, it will fail?


Repository:
  rL LLVM

https://reviews.llvm.org/D21189