[PATCH] D22822: Adjust coercion of aggregates on RenderScript

Stephen Hines via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 09:57:41 PDT 2016


srhines added a comment.

In https://reviews.llvm.org/D22822#497848, @t.p.northover wrote:

> > Actually no. We could fix it for some things going forward, but the Clang that they use will always need some form of this patch for generating IR to run on older devices.
>
>
> So do you have any kind of deprecation policy for older RS runtimes? It would be good to know that we won't have to live with this hack forever (and have some kind of comment in the code telling us when it can be nuked).


There is no deprecation policy for old runtimes because we support everything back to the original release of RS at this point. Any change made here would be only going forward (again assuming that the team agrees that this needs to go away, and that they aren't willing to put up with the performance issues for having it forever). Considering that all the code here is bracketed by RenderScript checks, it seems like it should be easy to remove any such section when an appropriate time comes. We can add more obvious comments that these checks are specifically for RS ABI issues (at least through Android N at this point).


https://reviews.llvm.org/D22822





More information about the llvm-commits mailing list