[PATCH] D22858: Fix DbgValue handling in SelectionDAG.

[Nirav Dave via llvm-commits]

niravd added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6659
@@ -6653,1 +6658,3 @@
+      ClonedDVs.push_back(Clone);
+      Dbg->setIsInvalidated();
     }
----------------
It's not 100% clear to me if these values should invalidated (i.e. moving the values or a copying). We only call TransferDbgValues from ReplaceUses* functions but it is possible that a value who's DbgValues are transferred can theoretically get a use later and so we might want to keep them. That said, intuitively such cases would be from a separate code location and we shouldn't leave the original DebugInfo around.








https://reviews.llvm.org/D22858