[PATCH] D22870: [AArch64] Return the correct size for TLSDESC_CALLSEQ

[Diana Picus via llvm-commits]

rovka added a comment.

It would be nice if we could identify other situations where this might happen - I'm not convinced GetInstSizeInBytes is catching all the special cases. At a quick glance through AArch64AsmPrinter, I think STACKMAP and PATCHPOINT might be other offenders. Is it worth looking into those as well?

On another line of thought, the original file [1] causing this bug is pretty huge and it might catch other things like this in the future - do we want to add it or something similar to the test-suite?

[1] https://llvm.org/bugs/attachment.cgi?id=15581


================
Comment at: lib/Target/AArch64/AArch64.h:51
@@ -50,2 +50,3 @@
 void initializeAArch64LoadStoreOptPass(PassRegistry&);
+void initializeAArch64BranchRelaxationPass(PassRegistry&);
 } // end namespace llvm
----------------
This won't be necessary if D22868 goes through, but I added it here to keep the patch self-contained (without this we can't run the test).


https://reviews.llvm.org/D22870