[PATCH] D22686: [WASM] SIMD128 support.

[Derek Schuff via llvm-commits]

dschuff added inline comments.

================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrCall.td:40
@@ +39,3 @@
+                         [(set (vt V128:$dst),
+			       (WebAssemblycall1 (i32 imm:$callee)))],
+                         !strconcat(prefix, "call\t$dst, $callee")>;
----------------
The indentation here (and line 45 and 70 and 107) looks funny.

================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrInfo.td:113
@@ -106,1 +112,3 @@
 defm : ARGUMENT<F64>;
+defm : SIMD_ARGUMENT<v16i8>;
+defm : SIMD_ARGUMENT<v8i16>;
----------------
Oh, one other thing that's a little unclear to me. Why do we need ARGUMENT_v16i8 et al instead of just ARGUMENT_V128? I guess it's because it corresponds to MVTs which can be vectors, instead of register classes? Register classes would seem to make more sense (and the other ARGUMENT multiclass is based on WebAssemblyRegClass?)


Repository:
  rL LLVM

https://reviews.llvm.org/D22686