[PATCH] D22373: [GlobalISel] Introduce a simple instruction selector.
Ahmed Bougacha via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 27 07:55:46 PDT 2016
ab added a comment.
Thanks all for the reviews! Committed r276875.
In https://reviews.llvm.org/D22373#495341, @qcolombet wrote:
> I'd move constrainSelectedInstRegOperands in the based class (as a static) to have it available for all the targets.
Done.
> Other than that LGTM, but please address the other comments first.
Thanks, let me know if I missed anything. We'll still need to discuss the vreg size/type and subtarget/MF issues, but I don't think those are specific to any individual pass.
Repository:
rL LLVM
https://reviews.llvm.org/D22373
More information about the llvm-commits
mailing list