[PATCH] D22811: [ELF] Linkerscript: allow setting custom output section for common symbols, instead of .bss

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 07:23:10 PDT 2016


evgeny777 updated this revision to Diff 65740.
evgeny777 added a comment.

George found a bug, review updated.

It turned out, that ArrayRef has this code for end():
iterator end() const { return Data + Length; }

So it is never nullptr.


https://reviews.llvm.org/D22811

Files:
  ELF/InputSection.cpp
  ELF/InputSection.h
  ELF/LinkerScript.cpp
  ELF/LinkerScript.h
  ELF/OutputSections.cpp
  ELF/SymbolTable.cpp
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/Writer.cpp
  test/ELF/linkerscript/linkerscript-common.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22811.65740.patch
Type: text/x-patch
Size: 18103 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160727/3e4dd95d/attachment.bin>


More information about the llvm-commits mailing list