[PATCH] D21994: [mips][ias] Check '$rs = $rd' constraints when both registers are in AsmText.

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 07:02:16 PDT 2016


sdardis added inline comments.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3720
@@ +3719,3 @@
+                   .isValidForTie(static_cast<MipsOperand &>(*Operands[2]))
+               ? Match_Success
+               : Match_RequiresSameSrcAndDst;
----------------
dsanders wrote:
> sdardis wrote:
> > GCC is reporting: enumeral mismatch in conditional expression: 'llvm::MCTargetAsmParser::MatchResultTy' vs '{anonymous::MipsParser::MipsMatchResultTy' here.
> I couldn't reproduce this one despite using the same compiler (gcc 4.9.2). I've committed without changing this bit but I'll see if any of the buildbots report it. Is that ok?
Yeah, that's fine.


https://reviews.llvm.org/D21994





More information about the llvm-commits mailing list