[PATCH] D22860: [ARM] Check that the thumb COFF segment flag gets set with a thumb windows triplet

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 06:45:53 PDT 2016


rengolin added inline comments.

================
Comment at: test/MC/ARM/Windows/thumb-attributes.s:14
@@ +13,3 @@
+
+@ CHECK: Sections [
+@ CHECK:   Section {
----------------
You don't need those, just the two DAGs after the Section. Something like:

    @ CHECK: Section
    @ CHECK-DAG: IMAGE_SCN_CNT_CODE
    ​@ CHECK-DAG: IMAGE_SCN_MEM_16BIT

Also, avoid using TABs.


https://reviews.llvm.org/D22860





More information about the llvm-commits mailing list