[PATCH] D22838: AMDGPU/SI: Implement amdgcn image intrinsics

[Nicolai Hähnle via llvm-commits]

nhaehnle added a subscriber: nhaehnle.

================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:193-198
@@ -192,11 +192,8 @@
 
 class AMDGPUImageLoad : Intrinsic <
   [llvm_v4f32_ty],    // vdata(VGPR)
   [llvm_anyint_ty,    // vaddr(VGPR)
    llvm_v8i32_ty,     // rsrc(SGPR)
    llvm_i32_ty,       // dmask(imm)
-   llvm_i1_ty,        // r128(imm)
-   llvm_i1_ty,        // da(imm)
-   llvm_i1_ty,        // glc(imm)
-   llvm_i1_ty],       // slc(imm)
+   llvm_i32_ty],      // flags (imm)
   [IntrReadMem]>;
----------------
Can we just not do this kind of change, please? I don't see how it improves anything, it's inconsistent with the ISA description which has the flags separate, and it'll require an annoying flag day synchronization with Mesa.


https://reviews.llvm.org/D22838