[PATCH] D22775: [ARM] Set a non-conflicting comment character for assembly in MSVC mode

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: test/MC/ARM/Windows/literals-comments.s:20
@@ +19,3 @@
+; CHECK:       IMAGE_SCN_ALIGN_4BYTES
+; CHECK:       IMAGE_SCN_CNT_CODE
+; CHECK:       IMAGE_SCN_MEM_EXECUTE
----------------
mstorsjo wrote:
> Once D22776 is solved, we should be able to add IMAGE_SCN_MEM_16BIT to the attributes checked here as well.
> 
> Or should I rather use a test with llvm-objdump -d, to check the encoding of the instructions? (The main point of the test is just that the assembly of the file shouldn't fail.)
I wouldn't think you'd need llvm-readobj at all. But would be good to make it clear what is testing, so I'd add a clear comment line:

    function:
      ; this is a comment
      mov r0, #42 ; this # was not
      bx lr



https://reviews.llvm.org/D22775