[PATCH] D22840: [InstCombine] Split int64 store into separate int32 stores

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 23:08:48 PDT 2016


Hmm, why does Clang change the return type from from struct to i64?  Set
aside whether it is always beneficial to do it or not, it certainly feels
like the wrong place to make such a change.

David

On Tue, Jul 26, 2016 at 10:40 PM, Wei Mi <wmi at google.com> wrote:

> wmi added a comment.
>
> Matt, David and Chandler, thanks for the review.
>
> I only looked at the code for x86-64, powerpc and aarch64 targets. For
> those targets, separate stores seemed better. I am not familiar with target
> like AMDGPU. I guess wider store is generally preferred than multiple
> narrower stores on AMDGPU? Since it may be undesirable on some targets, I
> agree it is more appropriate to implement it in SDAG pass. I will update
> the patch.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D22840
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160726/b016dcda/attachment.html>


More information about the llvm-commits mailing list