[PATCH] D22836: Add option to diable Bitcode tests. Tests are enabled by default.

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D22836#497219, @asbirlea wrote:

> Sounds good to me. 
>  As Mehdi pointed out, the apple compiler will probably want to use these tests as well, so I'm guessing we'll revisit the flag when the released version parses the bitcode correctly.


Well not really, the problem will stay forever (at some point our internal compiler will read the 3.9 bitcode but there might be some 4.0 bitcode). Also we're not the only downstream user, and other companies will have the same issue.

The approach @MatzeB took is a different philosophy from the one I was suggesting, basically he implemented opt-in while I was suggesting opt-out: an out-of-tree clang will have to explicitly pass the flag to get the tests enabled.

Either way (opt-in or opt-out) are fine to me, but I don't think we need to have code to handle every proprietary version system in the test-suite config upstream.


https://reviews.llvm.org/D22836