[PATCH] D22823: [CFLAA] Add getModRefBehavior() support to CFLAnders

[George Burgess IV via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

Two nits, because people tend to do cleanups to llvm's range algos. Otherwise, LGTM. Thanks for the patch!


================
Comment at: lib/Analysis/CFLAndersAliasAnalysis.cpp:873
@@ +872,3 @@
+    bool ArgAttributeIsWritten =
+        std::any_of(RetParamAttributes.begin(), RetParamAttributes.end(),
+                    [ArgIdx](const ExternalAttribute &ExtAttr) {
----------------
Nit: `llvm::any_of(RetParamAttributes, lambda)` (and the two others below)

================
Comment at: lib/Analysis/CFLAndersAliasAnalysis.cpp:934
@@ +933,3 @@
+  bool MemIsRead =
+      std::any_of(RetParamRelations.begin(), RetParamRelations.end(),
+                  [](const ExternalRelation &ExtRelation) {
----------------
Nit: `any_of(RetParamRelations, lambda)` (and below, for all_of)


https://reviews.llvm.org/D22823