[PATCH] D22825: Add a counter-function insertion pass

Honggyu Kim via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 19:00:54 PDT 2016


honggyu.kim added a comment.

In https://reviews.llvm.org/D22825#496681, @rjmccall wrote:

> In https://reviews.llvm.org/D22825#496680, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D22825#496546, @rjmccall wrote:
> >
> > > This seems like the right approach to me; I won't review the pass parts, though.  Should we do this + the change to actually start setting the flags in one patch?
> >
> >
> > Do you prefer that? I generally prefer when people split the Clang and LLVM patches into separate reviews (especially when they're functionally separable). On other other hand, if we move everything to one git repository, single patches will be easier...
>
>
> Ah, no, doing it separately is fine, then.


Hi, I have tested it and it works great for the backend. Thanks for the patch!


https://reviews.llvm.org/D22825





More information about the llvm-commits mailing list