[PATCH] D22795: [LinkerScript] Support EXCLUDE_FILE inside KEEP

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:681
@@ -672,2 +680,3 @@
+      InCmd->ExcludedFiles.push_back(next());
     Opt.KeptSections.push_back(peek());
     InCmd->Patterns.push_back(next());
----------------
davide wrote:
> ruiu wrote:
> > KeptSections shouldn't be updated in this function because this function should be agnostic of the context.
> So maybe we can pass an argument `std::vector<StringRef>` to collect the list of tokens and use that in readKeep() ?
File pattern consists of file names followed by section names, so std::vector<StringRef> is not enough because it is unstructured. Did you read my comment at line 694? Didn't it work?


https://reviews.llvm.org/D22795