[PATCH] D22673: AMDGPU: Track physical registers in SIWholeQuadMode

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 16:43:34 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:132
@@ -128,2 +131,3 @@
   void getAnalysisUsage(AnalysisUsage &AU) const override {
+    AU.addRequired<LiveIntervals>();
     AU.setPreservesCFG();
----------------
Should this also preserve it? Recomputing it if not used is quite expensive. I've also seen crashes when not preserving it (although I'm not 100% sure if that counts as a bug somewhere else)


https://reviews.llvm.org/D22673





More information about the llvm-commits mailing list