[PATCH] D22820: [GlobalISel] improved interface to MachineIRBuilder::buildInstr

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 15:24:14 PDT 2016


t.p.northover retitled this revision from "RFC[GlobalISel]: improved interface or unholy monstrosity?" to "[GlobalISel] improved interface to MachineIRBuilder::buildInstr".
t.p.northover updated this revision to Diff 65616.
t.p.northover added a comment.

OK, given the initial responses I've polished the patch up a bit and I'm converting it into a real review. I've not added all the weird corner-cases yet since we've got no real way to use them. Extending the interface as GlobalISel gains the features needed to test them ought to be a simple copy/paste/edit job.

OK to commit as is, or does anyone have some suggestions for improvements?


Repository:
  rL LLVM

https://reviews.llvm.org/D22820

Files:
  include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
  lib/CodeGen/GlobalISel/IRTranslator.cpp
  lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
  lib/Target/AArch64/AArch64CallLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22820.65616.patch
Type: text/x-patch
Size: 12004 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160726/7583d589/attachment.bin>


More information about the llvm-commits mailing list