[PATCH] D22630: Loop rotation

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 14:58:14 PDT 2016


sebpop added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/LoopRotation.cpp:431
@@ +430,3 @@
+    DEBUG(dbgs() << "\nSplitting the edge of Loop:"; L->dumpVerbose(););
+    LoopLatch = SplitEdge(LoopLatch, L->getHeader(), DT, LI);
+  }
----------------
hiraditya wrote:
> eli.friedman wrote:
> > The loop latch could be an indirectbr.
> I'll fix this, thanks.
I have the impression that the loop analysis will not find a natural loop if the edge from the latch to the header is an indirect branch.
Are you sure this is possible?  Do you have a test-case where we recognize a loop with an indirect branch for the latch edge?


https://reviews.llvm.org/D22630





More information about the llvm-commits mailing list