[PATCH] D22827: [test/gold] Add gold test subdirectory tests needing v1.12 (or higher)

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: test/tools/gold/X86/v1.12/lit.local.cfg:18
@@ +17,3 @@
+    return False
+  version = float(match.group(1))
+  if version < 1.12:
----------------
tejohnson wrote:
> davidxl wrote:
> > probably just look at the minor version and use integer comparison? version 1.2 should be older version right?
> Ah yes, good catch. I should probably compare both separately, in case the major version ever increases. Will fix.
Fixed.

================
Comment at: test/tools/gold/X86/v1.12/thinlto_emit_linked_objects.ll:13
@@ +12,3 @@
+; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
+; RUN:    --plugin-opt=thinlto \
+; RUN:    --plugin-opt=thinlto-index-only=%t3 \
----------------
hjl.tools wrote:
> "-m elf_x86_64" is needed for
> 
> target triple = "x86_64-unknown-linux-gnu"		​
Fixed


https://reviews.llvm.org/D22827