[PATCH] D22827: [test/gold] Add gold test subdirectory tests needing v1.12 (or higher)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 11:39:32 PDT 2016


tejohnson created this revision.
tejohnson added reviewers: davidxl, mehdi_amini.
tejohnson added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

As discussed in the review for D22677, added a subdirectory to
enable tests that require at least version 1.12 of gold.

Add an initial test requiring this version.

Another option would be to add this as a new available_feature in
test/lit.cfg and place the new tests directly in test/tools/gold/X86
with a REQUIRES tag.

https://reviews.llvm.org/D22827

Files:
  test/tools/gold/X86/v1.12/Inputs/thinlto_emit_linked_objects.ll
  test/tools/gold/X86/v1.12/lit.local.cfg
  test/tools/gold/X86/v1.12/thinlto_emit_linked_objects.ll

Index: test/tools/gold/X86/v1.12/thinlto_emit_linked_objects.ll
===================================================================
--- /dev/null
+++ test/tools/gold/X86/v1.12/thinlto_emit_linked_objects.ll
@@ -0,0 +1,29 @@
+; First generate bitcode with a module summary index for each file
+; RUN: opt -module-summary %s -o %t.o
+; RUN: opt -module-summary %p/Inputs/thinlto_emit_linked_objects.ll -o %t2.o
+
+; Next do the ThinLink step, specifying thinlto-index-only so that the gold
+; plugin exits after generating individual indexes. The objects the linker
+; decided to include in the link should be emitted into the file specified
+; after 'thinlto-index-only='. In this version of the test, only %t.o will
+; be included in the link, and not %t2.o since it is within
+; a library (--start-lib/--end-lib pair) and not strongly referenced.
+; Note that the support for detecting this is in gold v1.12.
+; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
+; RUN:    --plugin-opt=thinlto \
+; RUN:    --plugin-opt=thinlto-index-only=%t3 \
+; RUN:    -o %t4 \
+; RUN:    %t.o \
+; RUN:    --start-lib %t2.o --end-lib
+
+; RUN: cat %t3 | FileCheck %s
+; CHECK: thinlto_emit_linked_objects.ll.tmp.o
+; CHECK-NOT: thinlto_emit_linked_objects.ll.tmp2.o
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define i32 @main() {
+entry:
+  ret i32 0
+}
Index: test/tools/gold/X86/v1.12/lit.local.cfg
===================================================================
--- /dev/null
+++ test/tools/gold/X86/v1.12/lit.local.cfg
@@ -0,0 +1,25 @@
+import re
+import subprocess
+
+def is_gold_v1_12_linker_available():
+
+  if not config.gold_executable:
+    return False
+  try:
+    ld_cmd = subprocess.Popen([config.gold_executable, '-v'], stdout = subprocess.PIPE)
+    ld_out = ld_cmd.stdout.read().decode()
+    ld_cmd.wait()
+  except:
+    return False
+
+  match = re.search(r'GNU gold \(.*\) (\d+.\d+)$', ld_out)
+  if not match:
+    return False
+  version = float(match.group(1))
+  if version < 1.12:
+    return False
+
+  return True
+
+if not is_gold_v1_12_linker_available():
+  config.unsupported = True
Index: test/tools/gold/X86/v1.12/Inputs/thinlto_emit_linked_objects.ll
===================================================================
--- /dev/null
+++ test/tools/gold/X86/v1.12/Inputs/thinlto_emit_linked_objects.ll
@@ -0,0 +1,7 @@
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @foo() {
+entry:
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22827.65568.patch
Type: text/x-patch
Size: 2562 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160726/ff19d770/attachment.bin>


More information about the llvm-commits mailing list