[llvm] r276109 - [docs] Fixing Sphinx warnings to unclog the buildbot

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 09:25:30 PDT 2016


On Tue, Jul 26, 2016 at 12:22 PM, Hans Wennborg <hans at chromium.org> wrote:
> On Tue, Jul 26, 2016 at 9:12 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
>> On Tue, Jul 26, 2016 at 12:06 PM, Hans Wennborg via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> I went ahead and merged to 3.9 in r276758.
>>
>> We may want to double-check that this is sufficient to fix 3.9's
>> documentation building issues. I did a handful of related one-off
>> commits along the same lines that we may have to pull in as well (I
>> can try to locate those commits if the docs build isn't fixed in 3.9
>> by this merge).
>
> Thanks. I haven't started looking at building the docs yet, but if it
> doesn't work I'll have a look at your commits.

Sounds good. If you want help tracking them down, feel free to ask; I
am happy to do that work.

~Aaron

>
> Cheers,
> Hans
>
>
>>> On Tue, Jul 26, 2016 at 5:30 AM, Hahnfeld, Jonas
>>> <Hahnfeld at itc.rwth-aachen.de> wrote:
>>>> Ping, would be great.
>>>>
>>>> Thanks,
>>>> Jonas
>>>>
>>>>> -----Original Message-----
>>>>> From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf
>>>>> Of Hans Wennborg
>>>>> Sent: Wednesday, July 20, 2016 3:28 PM
>>>>> To: Hahnfeld, Jonas
>>>>> Cc: Renato Golin; llvm-commits at lists.llvm.org
>>>>> Subject: Re: [llvm] r276109 - [docs] Fixing Sphinx warnings to unclog the
>>>>> buildbot
>>>>>
>>>>> Sounds good to me. Renato, would you like to merge this over to 3.9?
>>>>>
>>>>> Thanks,
>>>>> Hans
>>>>>
>>>>> On Wed, Jul 20, 2016 at 8:50 AM, Hahnfeld, Jonas <Hahnfeld at itc.rwth-
>>>>> aachen.de> wrote:
>>>>> > Hi,
>>>>> >
>>>>> > Thanks for fixing these, I also hit them recently.
>>>>> > Should this be merged for 3.9 to allow the docs being built with
>>>>> > sphinx 1.4 which I think they currently do not?
>>>>> >
>>>>> > Thanks,
>>>>> > Jonas
>>>>> >
>>>>> >> -----Original Message-----
>>>>> >> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
>>>>> >> Behalf Of Renato Golin via llvm-commits
>>>>> >> Sent: Wednesday, July 20, 2016 2:17 PM
>>>>> >> To: llvm-commits at lists.llvm.org
>>>>> >> Subject: [llvm] r276109 - [docs] Fixing Sphinx warnings to unclog the
>>>>> >> buildbot
>>>>> >>
>>>>> >> Author: rengolin
>>>>> >> Date: Wed Jul 20 07:16:38 2016
>>>>> >> New Revision: 276109
>>>>> >>
>>>>> >> URL: http://llvm.org/viewvc/llvm-project?rev=276109&view=rev
>>>>> >> Log:
>>>>> >> [docs] Fixing Sphinx warnings to unclog the buildbot
>>>>> >>
>>>>> >> Lots of blocks had "llvm" or "nasm" syntax types but either weren't
>>>>> >> following the syntax, or the syntax has changed (and sphinx hasn't
>>>>> >> keep up) or the type doesn't even exist (nasm?).
>>>>> >>
>>>>> >> Other documents had :options: what were invalid. I only removed those
>>>>> >> that had warnings, and left the ones that didn't, in order to follow
>>>>> >> the principle of least surprise.
>>>>> >>
>>>>> >> This is like this for ages, but the buildbot is now failing on
>>>>> >> errors. It may take a while to upgrade the buildbot's sphinx, if
>>>>> >> that's even possible, but that shouldn't stop us from getting docs
>>>>> >> updates (which seem down for quite a while).
>>>>> >>
>>>>> >> Also, we're not losing any syntax highlight, since when it doesn't
>>>>> >> parse, it doesn't colour. Ie. those blocks are not being highlighted
>>>>> >> anyway.
>>>>> >>
>>>>> >> I'm trying to get all docs in one go, so that it's easy to revert
>>>>> >> later if we do fix, or at least easy to know what's to fix.
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list