[PATCH] D22630: Loop rotation

[Sebastian Pop via llvm-commits]

sebpop added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/LoopRotation.cpp:676
@@ -675,3 @@
-    auto *SE = SEWP ? &SEWP->getSE() : nullptr;
-    LoopRotate LR(MaxHeaderSize, LI, TTI, AC, DT, SE);
-    return LR.processLoop(L);
----------------
Meinersbur wrote:
> Doesn't ScalarEvolution need be updated anymore? `getLoopAnalysisUsage()` adds `SCEVAAWrapperPass` (but not `ScalarEvolution` itself?)
The previous version of loop rotation was using the SE analysis.  Our revised loop rotation does not require SE: it only works on the CFG and DT.  There is no need to invalidate the SE, as LoopRotation adds new phi nodes, and the old phi nodes are removed.


https://reviews.llvm.org/D22630