[PATCH] D22760: [ARM] Implement -mimplicit-it assembler option
Tim Northover via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 26 06:47:25 PDT 2016
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Thanks Oli. I think this looks fine now.
Tim.
================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:176
@@ -149,3 +175,3 @@
ARMCC::CondCodes Cond; // Condition for IT block.
unsigned Mask:4; // Condition mask for instructions.
// Starting at first 1 (from lsb).
----------------
OK, I was just considering the later instructions. That makes reasonable sense.
================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:9036
@@ +9035,3 @@
+
+ // Finish the current IT block, and try to match outside any IT block.
+ flushPendingInstructions(Out);
----------------
Yes, sorry. Just considered that possibility this morning.
https://reviews.llvm.org/D22760
More information about the llvm-commits
mailing list