[PATCH] D22800: [tsan] Fix behavior of realloc(nullptr, 0) on Darwin

[Kuba Brecka via llvm-commits]

kubabrecka created this revision.
kubabrecka added a reviewer: dvyukov.
kubabrecka added subscribers: zaks.anna, llvm-commits.
kubabrecka added a project: Sanitizers.
Herald added a subscriber: kubabrecka.

On Darwin, there are some apps that rely on `realloc(nullptr, 0)` returning a valid pointer.  TSan currently returns nullptr in this case, let's fix it to avoid breaking binary compatibility.

https://reviews.llvm.org/D22800

Files:
  lib/tsan/rtl/tsan_mman.cc
  test/tsan/Darwin/realloc-zero.cc

Index: test/tsan/Darwin/realloc-zero.cc
===================================================================
--- test/tsan/Darwin/realloc-zero.cc
+++ test/tsan/Darwin/realloc-zero.cc
@@ -0,0 +1,20 @@
+// Test that realloc(nullptr, 0) return a non-NULL pointer.
+
+// RUN: %clang_tsan %s -o %t
+// RUN: %run %t 2>&1 | FileCheck %s
+
+#include <malloc/malloc.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <sys/mman.h>
+
+int main() {
+  void *p = realloc(nullptr, 0);
+  if (!p) {
+    abort();
+  }
+  fprintf(stderr, "Okay.");
+  return 0;
+}
+
+// CHECK: Okay.
Index: lib/tsan/rtl/tsan_mman.cc
===================================================================
--- lib/tsan/rtl/tsan_mman.cc
+++ lib/tsan/rtl/tsan_mman.cc
@@ -195,20 +195,16 @@
 }
 
 void *user_realloc(ThreadState *thr, uptr pc, void *p, uptr sz) {
-  void *p2 = 0;
   // FIXME: Handle "shrinking" more efficiently,
   // it seems that some software actually does this.
-  if (sz) {
-    p2 = user_alloc(thr, pc, sz);
-    if (p2 == 0)
-      return 0;
-    if (p) {
-      uptr oldsz = user_alloc_usable_size(p);
-      internal_memcpy(p2, p, min(oldsz, sz));
-    }
-  }
-  if (p)
+  void *p2 = user_alloc(thr, pc, sz);
+  if (p2 == 0)
+    return 0;
+  if (p) {
+    uptr oldsz = user_alloc_usable_size(p);
+    internal_memcpy(p2, p, min(oldsz, sz));
     user_free(thr, pc, p);
+  }
   return p2;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22800.65489.patch
Type: text/x-patch
Size: 1382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160726/ecc4c3e7/attachment.bin>