[PATCH] D22776: [ARM] Set the thumb flag for all text segments on COFF (partial revert of recent commit)

[Renato Golin via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D22776#495638, @compnerd wrote:

> We actually do not support non-Windows COFF AFAIK.  We have many places where we assert that this is the case.  Windows ARM is a pure thumb-2 environment, so its a relatively safe assumption to make.


It may be a safe assumption, but that's bad code. If that's always true, than whatever that flag was representing is no longer relevant.

My point is that the behaviour is broken. Martin said even with thumb markers the code is still coming up as ARM, and that's wrong. If we fix that, we can still have the flag as it is.


https://reviews.llvm.org/D22776