[PATCH] D22776: [ARM] Set the thumb flag for all text segments on COFF (partial revert of recent commit)

[Renato Golin via llvm-commits]

rengolin added reviewers: compnerd, jroelofs.
rengolin added a comment.

In https://reviews.llvm.org/D22776#495298, @mstorsjo wrote:

> True (and the code I'm working with obviously has such markers as well). Even if files have Thumb markers, the code currently just looks for the triplet (which was set at the start of the session), disregarding whatever mode currently is used.


Right, this sounds terribly wrong. :)

Unfortunately, assuming Thumb even when market ARM is not the solution. What if someone actually chose -marm with COFF?

> How much harder is a proper fix for this issue? (I'm quite unfamiliar with the LLVM codebase so far, and unfortunately don't have much time to spare. So in case it's a much larger scope, I'm afraid I'll have to defer this to a bug report.)


That's a good question. I'm unfamiliar with COFF and Windows as well. I'm adding some folks to chime in.


https://reviews.llvm.org/D22776