[PATCH] D22368: Replace hot-callsite based heuristic to use its own threshold parameter instead of share inline-hint parameter

[Easwaran Raman via llvm-commits]

eraman added a comment.

LGTM.

[Copying Dehao's comments from the review thread for reference]

I experimented different thresholds from 325 (original) to 4000. The code size change is within 2% fall all speccpu2006 int benchmarks. In terms of performance. Up to 4% speedup is observed for perlbench when changing threshold from 325 to 3000. And above 3000, the performance curve remains flat. For all other speccpu2006 int benchmarks, the performance change does not escape noise range when changing threshold from 325 to 4000. Similar performance/size result is observed for internal benchmarks. So I think 3000 seems to be a sweet spot for the threshold.


https://reviews.llvm.org/D22368