[PATCH] D22491: Added ThinLTO inlining statistics

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: test/Transforms/Inline/inline_stats.ll:18
@@ +17,3 @@
+; CHECK: non-imported functions inlined into importing module: 1 [33.33% of non-imported functions]
+
+define void @internal() {
----------------
Prazek wrote:
> you mean substract imported functions from inlined imported functions?
> 
> like
>  imported functions not inlined anywhere: 3 [~43% of imported functions]
Meaning subtract "imported functions inlined into importing module" from "imported functions" (4 in the above example).

================
Comment at: test/Transforms/Inline/inline_stats.ll:18
@@ +17,3 @@
+; CHECK: non-imported functions inlined into importing module: 1 [33.33% of non-imported functions]
+
+define void @internal() {
----------------
tejohnson wrote:
> Prazek wrote:
> > you mean substract imported functions from inlined imported functions?
> > 
> > like
> >  imported functions not inlined anywhere: 3 [~43% of imported functions]
> Meaning subtract "imported functions inlined into importing module" from "imported functions" (4 in the above example).
I'm less sure about how we will use the last one (non-imported functions inlined into importing module vs non-imported functions inlined anywhere), but for the imported functions what we primarily want to see is how many/what percentage were inlined into the importing module.


https://reviews.llvm.org/D22491