[PATCH] D22693: More strongly separate the PDB reading interfaces and PDB writing interfaces

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/DebugInfo/Msf/MappedBlockStream.cpp:191
@@ -162,4 +190,3 @@
   uint32_t NumAdditionalBlocks =
-      llvm::alignTo(Size - BytesFromFirstBlock, Msf.getBlockSize()) /
-      Msf.getBlockSize();
+      llvm::alignTo(Size - BytesFromFirstBlock, BlockSize) / BlockSize;
 
----------------
amccarth wrote:
> Is this correct?  If `Size` is two blocks and `BytesFromFirstBlock` is less than `BlockSize`, then we'll get two additional blocks instead of one.
Perhaps:
  uint32_t NumAdditionalBlocks = (llvm::alignTo(Size, BlockSize) / BlockSize) - 1;
?


https://reviews.llvm.org/D22693