[PATCH] D22749: [ELF] - Linkerscript: Implemented SORT command

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 07:15:21 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:139
@@ +138,3 @@
+            });
+      for (InputSectionBase<ELFT> *I : Candidates)
+        AddInputSec(I, OutCmd->Name, OutCmd->Constraint);
----------------
emaste wrote:
> My comment crossed your update. To be clear, I think the current version of this block is correct.
Yep, I understood. Thanks !
Btw I think I never saw sorting by filenames in scripts. I think it is not common and we can postpone the support. What do you think ?


https://reviews.llvm.org/D22749





More information about the llvm-commits mailing list