[PATCH] D22706: Fix : Partial Inliner requires AssumptionCacheTracker

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: /Users/rriddle/Desktop/llvm/llvm/lib/Transforms/IPO/PartialInlining.cpp:123
@@ -83,5 +122,3 @@
   duplicateFunction->setLinkage(GlobalValue::InternalLinkage);
-  BasicBlock* newEntryBlock = cast<BasicBlock>(VMap[entryBlock]);
-  BasicBlock* newReturnBlock = cast<BasicBlock>(VMap[returnBlock]);
-  BasicBlock* newNonReturnBlock = cast<BasicBlock>(VMap[nonReturnBlock]);
-  
+  BasicBlock *newEntryBlock = cast<BasicBlock>(VMap[entryBlock]);
+  BasicBlock *newReturnBlock = cast<BasicBlock>(VMap[returnBlock]);
----------------
Can you split these formatting changes into a separate patch after this one? Even better, formatting + updating the naming would be a very welcome patch for this pass.

================
Comment at: /Users/rriddle/Desktop/llvm/llvm/test/Transforms/Inline/partial-inline-act.ll:4
@@ +3,3 @@
+
+define internal i32 @inlinedFunc(i1, i32* align 4) {
+entry:
----------------
Can you please put explicit names on the arguments (even just %0 and %1)?


https://reviews.llvm.org/D22706