[PATCH] D22739: [ELF] Fix the semantic of PROVIDE in Linker scripts
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 24 17:27:38 PDT 2016
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/LinkerScript.cpp:355-356
@@ +354,4 @@
+ // The semantic of PROVIDE is that of introducing a symbol
+ // only if it's not defined and there's at least a reference
+ // to it.
+ if ((!B && !Cmd->Provide) || (B && B->isUndefined()))
----------------
Move "to it." to the end of previous line.
https://reviews.llvm.org/D22739
More information about the llvm-commits
mailing list