[PATCH] D21460: [JumpThreading] Fix handling of aliasing metadata.

[Hal Finkel via llvm-commits]

hfinkel added inline comments.

================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:965
@@ +964,3 @@
+          LLVMContext::MD_dereferenceable_or_null};
+      combineMetadata(NLI, LI, KnownIDs);
+    };
----------------
hiraditya wrote:
> The declaration of KnownIDs seem to be repeated at other places e.g., line 827. Is there a way to merge them, possibly put them all in a separate function.
I agree; we'll now have this list of 'metadata which is safe to merge on memory-access CSE'. Let's put this list somewhere common.

================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:975
@@ -974,3 +986,3 @@
   // then we can propagate them onto any newly inserted loads.
   AAMDNodes AATags;
   LI->getAAMetadata(AATags);
----------------
Is AATags now dead?


https://reviews.llvm.org/D21460