[lld] r276536 - [ELF/Linkerscript] Define an absolute if we find an undefined.

[Davide Italiano via llvm-commits]

Author: davide
Date: Sat Jul 23 17:09:04 2016
New Revision: 276536

URL: http://llvm.org/viewvc/llvm-project?rev=276536&view=rev
Log:
[ELF/Linkerscript] Define an absolute if we find an undefined.

Otherwhise undefined references to symbols defined in linker scripts
are never resolved.

Differential Revision:  https://reviews.llvm.org/D22664

Added:
    lld/trunk/test/ELF/linkerscript-undef.s
Modified:
    lld/trunk/ELF/LinkerScript.cpp

Modified: lld/trunk/ELF/LinkerScript.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=276536&r1=276535&r2=276536&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.cpp (original)
+++ lld/trunk/ELF/LinkerScript.cpp Sat Jul 23 17:09:04 2016
@@ -532,7 +532,8 @@ template <class ELFT> void LinkerScript<
     if (!Cmd || Cmd->Name == ".")
       continue;
 
-    if (Symtab<ELFT>::X->find(Cmd->Name) == nullptr)
+    SymbolBody *B = Symtab<ELFT>::X->find(Cmd->Name);
+    if (!B || B->isUndefined())
       Symtab<ELFT>::X->addAbsolute(Cmd->Name,
                                    Cmd->Hidden ? STV_HIDDEN : STV_DEFAULT);
     else

Added: lld/trunk/test/ELF/linkerscript-undef.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/linkerscript-undef.s?rev=276536&view=auto
==============================================================================
--- lld/trunk/test/ELF/linkerscript-undef.s (added)
+++ lld/trunk/test/ELF/linkerscript-undef.s Sat Jul 23 17:09:04 2016
@@ -0,0 +1,11 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+
+# RUN: echo "SECTIONS { patatino = 0x1234; }" > %t.script
+# RUN: ld.lld -o %t1 --script %t.script %t
+# RUN: llvm-objdump -t %t1 | FileCheck %s
+# CHECK: 0000000000001234         *ABS*    00000000 patatino
+
+.global _start
+_start:
+  call patatino