[PATCH] D22703: [PM] Port SymbolRewriter to the new PM
Duncan P. N. Exon Smith via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 23 06:57:26 PDT 2016
> On 2016-Jul-22, at 17:41, Michael Kuperstein via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> 2) I've converted the iplist into a std::list<unique_ptr>, because iplist is not moveable. Does this seem reasonable?
It's probably trivial to add move operations to iplist, but there's no motivation here. I don't see any reason to be using an iplist. std::list<unique_ptr> is clearer.
That's a fairly large (and NFC) part of the patch. I think it should be split out and committed separately.
More information about the llvm-commits
mailing list