[PATCH] D22619: Simplify error reporting in YAMLParser

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 16:20:06 PDT 2016


Bigcheese added a comment.

There are some cases where it looks like the argument isn't the same as Current. Is this actually the case?


================
Comment at: lib/Support/YAMLParser.cpp:998-999
@@ -997,4 +993,3 @@
       if (i->IsRequired)
-        setError( "Could not find expected : for simple key"
-                , i->Tok->Range.begin());
       i = SimpleKeys.erase(i);
----------------
This one appears to change behavior with this patch. I don't believe this will ever be the same token as Current.


https://reviews.llvm.org/D22619





More information about the llvm-commits mailing list