[PATCH] D22377: [SCEV] trip count calculation for loops with unknown stride

[Pankaj Chawla via llvm-commits]

pankajchawla added a comment.

Hi Sanjoy,

> If I understand you correctly, you're saying that even if the stride

>  is negative the expression that computes the backedge taken count is

>  valid. That may be correct (I'll re-review with that understanding),

>  but then the change description needs to say that instead of saying

>  "then we can assume the stride to be positive." Is that a correct

>  assessment?


Your assessment is correct :)
I have updated the description. Hopefully, it makes more sense now. I am not sure what is the correct terminology to use here.

> Btw, if you think a real-time chat can help and are in PDT, we can

>  talk about this on the #llvm IRC channel on Monday.


Yes, I am in PDT but now that (I think) we are on the same page this may not be needed. We can chat if you still think it is needed.


https://reviews.llvm.org/D22377