[PATCH] D22491: Added ThinLTO inlining statistics

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 12:10:23 PDT 2016


mehdi_amini added a comment.

I prefer the middle end to stay as much agnostic of the exact "use case" (ThinLTO) and focus on the "feature" from a library point of view: so I'd rather see "functionimport" used instead of "ThinLTO".
I.e. any system that would use some importing mechanism to implement a runtime in a JIT environment may be interested in this. We design LLVM as reusable and independent components.


================
Comment at: lib/Transforms/Utils/ThinLTOInlinerStats.cpp:92
@@ +91,3 @@
+};
+
+ThinLTOInlinerStatistics::ThinLTOInlinerStatistics() { NonImportedCallers.reserve(200); }
----------------
We don't add mutexes without motivation. You need to explain why *this* one makes sense (I.e. how it could get use in a multi-threaded environment in the future).


https://reviews.llvm.org/D22491





More information about the llvm-commits mailing list