[PATCH] D22634: [CFLAA] Add support for field offset in CFLAnders::FunctionInfo

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 11:26:32 PDT 2016


george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM -- thanks for the patch!


================
Comment at: lib/Analysis/CFLAndersAliasAnalysis.cpp:540
@@ +539,3 @@
+        // Try to be conservative on super large offsets
+        if (LLVM_UNLIKELY(LHSSize > INT64_MAX || RHSSize > INT64_MAX))
+          return true;
----------------
> If PartialAlias = MustAlias at nonzero offset, then we probably don't have anything smarter than MayAlias, since the analysis only handles may info

Agreed :)


https://reviews.llvm.org/D22634





More information about the llvm-commits mailing list