[PATCH] D22688: [PM] Port BreakCriticalEdges to the new PM

[Davide Italiano via llvm-commits]

davide added a comment.

The structure is OK (modulo nit), but I have a comment about the tests.


================
Comment at: lib/Transforms/Utils/BreakCriticalEdges.cpp:49
@@ +48,3 @@
+    auto *LI = LIWP ? &LIWP->getLoopInfo() : nullptr;
+    unsigned N = SplitAllCriticalEdges(F, CriticalEdgeSplittingOptions(DT, LI));
+    NumBroken += N;
----------------
This line is unchanged, right? If yes, you can remove that to improve the commit readability.

================
Comment at: test/Analysis/Dominators/2006-10-02-BreakCritEdges.ll:2
@@ -1,2 +1,3 @@
 ; RUN: opt < %s -domtree -break-crit-edges -analyze -domtree | FileCheck %s
+; RUN: opt < %s -passes='require<domtree>,break-crit-edges,print<domtree>' -disable-output 2>&1| FileCheck %s
 ; PR932
----------------
Here you have `-domtree -break-critical-egdes -domtree` which in the new PM becomes `require<domtree>,break-crit-edges,print<domtree>`.
In the next test you have (almost) the same line which instead becomes 
`require<domtree>,break-crit-edges,require<domtree>`.
What is the reason of this difference? (maybe I'm missing the obvious here).


Repository:
  rL LLVM

https://reviews.llvm.org/D22688