[PATCH] D22677: [ThinLTO/gold] Support for getting list of included objects from gold

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 08:59:05 PDT 2016


davidxl added a comment.

How about adding functional test cases to cover issues mentioned in the mentioned previous reviews?


================
Comment at: test/tools/gold/X86/thinlto_emit_linked_objects.ll:18
@@ +17,3 @@
+; RUN:    %t.o \
+; RUN:    --start-lib %t2.o --end-lib
+
----------------
Perhaps add test case about real archive case as well.

================
Comment at: test/tools/gold/X86/thinlto_emit_linked_objects.ll:21
@@ +20,3 @@
+; RUN: cat %t3 | FileCheck %s
+; CHECK: thinlto_emit_linked_objects.ll.tmp.o
+; CHECK: thinlto_emit_linked_objects.ll.tmp2.o
----------------
Can the name between bitcode file and final object files be made more related ? 


https://reviews.llvm.org/D22677





More information about the llvm-commits mailing list