[PATCH] D19272: [ELF] - linkerscript AT keyword (in output section description) implemented.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 06:40:24 PDT 2016


grimar added inline comments.

================
Comment at: test/ELF/linkerscript-at.s:66
@@ +65,3 @@
+# CHECK-NEXT:     VirtualAddress: 0x1010
+# CHECK-NEXT:     PhysicalAddress: 0x3000
+# CHECK-NEXT:     FileSize: 8
----------------
evgeny777 wrote:
> I have feeling that section alignment is not done for LMA
I guess you meant VMA. 

As far I understand the feature, AT just sets the physical address field of PT_LOAD. VMA is different and should be controlled
by location counter or something else. Setting PA gives ability to control LMA for sections.
I think the output after applying my patch is equal to what gnu ld do.
gold also touches the file offsets of the sections, gnu ld does not, this patch also does not.

Would be interesting to hear opinion from reviewers


https://reviews.llvm.org/D19272





More information about the llvm-commits mailing list