[PATCH] D22672: [ELF] - Linkerscript: cleanup of LinkerScript<ELFT>::createSections().
Eugene Leviant via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 22 05:34:16 PDT 2016
evgeny777 added inline comments.
================
Comment at: ELF/LinkerScript.cpp:261
@@ -260,1 +260,3 @@
template <class ELFT>
+bool canAddSection(InputSectionBase<ELFT> *C, ConstraintKind Kind) {
+ if (Kind == NoConstraint)
----------------
grimar wrote:
> forgot static, will add if approved.
Will it be called from anywhere else except lambda?
I suggest making it static for now
https://reviews.llvm.org/D22672
More information about the llvm-commits
mailing list