[PATCH] D21994: [mips][ias] Check '$rs = $rd' constraints when both registers are in AsmText.

[Simon Dardis via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with the two nits addressed (inlined).


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1468
@@ -1440,1 +1467,3 @@
+    }
+  }
 }; // class MipsOperand
----------------
GCC 4.9.2 is reporting: control reaches end of non-void function [-Wreturn-type] here.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3720
@@ +3719,3 @@
+                   .isValidForTie(static_cast<MipsOperand &>(*Operands[2]))
+               ? Match_Success
+               : Match_RequiresSameSrcAndDst;
----------------
GCC is reporting: enumeral mismatch in conditional expression: 'llvm::MCTargetAsmParser::MatchResultTy' vs '{anonymous::MipsParser::MipsMatchResultTy' here.


https://reviews.llvm.org/D21994