[compiler-rt] r275539 - [asan] Reduce flakiness of halt_on_error-torture.cc testcase.

[Kostya Serebryany via llvm-commits]

Do you think this is fully fixed?
I've seen it fail on my local machine just now (passes when I repeat)

On Fri, Jul 15, 2016 at 12:57 AM, Maxim Ostapenko via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: chefmax
> Date: Fri Jul 15 02:57:43 2016
> New Revision: 275539
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275539&view=rev
> Log:
> [asan] Reduce flakiness of halt_on_error-torture.cc testcase.
>
> It seems in some situations we have clashes on very first error so test
> only prints "nested bug in the same thread, aborting" rather than
> "use-after-poison", so remove corresponding " RUN: FileCheck %s < 10.txt"
> line.
> Also, the two last " RUN: FileCheck --check-prefix=CHECK-COLLISION %s <
> 1.txt || FileCheck --check-prefix=CHECK-NO-COLLISION %s < 1.txt" look
> wrong, they should check 10.txt. Fix these lines too.
>
> Differential Revision: https://reviews.llvm.org/D22309
>
> Modified:
>     compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
>
> Modified:
> compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc?rev=275539&r1=275538&r2=275539&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
> (original)
> +++ compiler-rt/trunk/test/asan/TestCases/Posix/halt_on_error-torture.cc
> Fri Jul 15 02:57:43 2016
> @@ -9,15 +9,11 @@
>  //
>  // Collisions are unlikely but still possible so we need the ||.
>  // RUN: %env_asan_opts=halt_on_error=false:suppress_equal_pcs=false %run
> %t 10 20 >10.txt 2>&1 || true
> -// This one is racy although _very_ unlikely to fail:
> -// RUN: FileCheck %s < 10.txt
> -// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt || FileCheck
> --check-prefix=CHECK-NO-COLLISION %s < 1.txt
> +// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt || FileCheck
> --check-prefix=CHECK-NO-COLLISION %s < 10.txt
>  //
>  // Collisions are unlikely but still possible so we need the ||.
>  // RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >10.txt 2>&1 ||
> true
> -// This one is racy although _very_ unlikely to fail:
> -// RUN: FileCheck %s < 10.txt
> -// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 1.txt || FileCheck
> --check-prefix=CHECK-NO-COLLISION %s < 1.txt
> +// RUN: FileCheck --check-prefix=CHECK-COLLISION %s < 10.txt || FileCheck
> --check-prefix=CHECK-NO-COLLISION %s < 10.txt
>
>  #include <stdio.h>
>  #include <stdlib.h>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160721/f96c81b0/attachment.html>