[PATCH] D22648: [PM] Port NaryReassociate to the new PM

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 14:48:44 PDT 2016


On Thu, Jul 21, 2016 at 2:46 PM, Wei Mi <wmi at google.com> wrote:

> wmi added inline comments.
>
> ================
> Comment at: test/Transforms/NaryReassociate/nary-mul.ll:2
> @@ -1,2 +1,3 @@
>  ; RUN: opt < %s -nary-reassociate -S | FileCheck %s
> +; RUN: opt < %s -passes='nary-reassociate' -S | FileCheck %s
>
> ----------------
> davidxl wrote:
> > How about other tests in the same dir?
> I saw the guildeline in https://reviews.llvm.org/rL272505 said one test
> changed was enough. I just tried other tests and they passed. Do you want
> me to include them?
>
>
The point is that when old PM is deprecated, the tests need to be changed
anyway. THere is also a chance more tests can uncover issues.

David


>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D22648
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160721/0b54eb3c/attachment.html>


More information about the llvm-commits mailing list