[PATCH] D22650: AMDGPU/R600: Convert buffer_id to VTX_READ input
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 21 14:34:43 PDT 2016
arsenm added a comment.
What's the reason for moving to separate patterns?
================
Comment at: lib/Target/AMDGPU/EvergreenInstructions.td:144-145
@@ -143,3 +143,4 @@
let FETCH_WHOLE_QUAD = 0;
- let BUFFER_ID = buffer_id;
+// this is set by tablegen magic
+// let BUFFER_ID = $BUFFER_ID;
let SRC_REL = 0;
----------------
Capitalize, indent comment and remove commented out line. The comment should probably go on the encoding bit definition
Repository:
rL LLVM
https://reviews.llvm.org/D22650
More information about the llvm-commits
mailing list