[PATCH] D22613: [Profile] deprecate __llvm_profile_override_default_filename (part-1)

[Vedant Kumar via llvm-commits]

vsk added a comment.

Nice, just one concern.


================
Comment at: lib/Transforms/Instrumentation/InstrProfiling.cpp:615
@@ +614,3 @@
+      ProfileNameVar->setComdat(M->getOrInsertComdat(
+          StringRef(INSTR_PROF_QUOTE(INSTR_PROF_PROFILE_NAME_VAR))));
+  }
----------------
What's the advantage of placing the file name var in a comdat if it already has weak linkage? Would some ELF tests break without this?


https://reviews.llvm.org/D22613